Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Ldn8 Judith Ricketts CSS Grid - Cakes #269

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

LovesPictures
Copy link

@LovesPictures LovesPictures commented Dec 3, 2021

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

#- Your Name: Judith Ricketts

  • Your City: Ldn8
  • Your Slack Name: Loves Pictures

Homework Details

  • Module: CSS Grid
  • Week: W4

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?


View rendered .github/pull_request_template.md
View rendered GRADING.md
View rendered HOW-TO-GET-HELP.md
View rendered HOW-TO-SUBMIT.md
View rendered HOW_TO_MARK.md

@LovesPictures LovesPictures changed the title Initial commit Ldn8 Judith Ricketts Initial commit Dec 3, 2021
@LovesPictures LovesPictures changed the title Ldn8 Judith Ricketts Initial commit Ldn8 Judith Ricketts CSS Grid - Cakes Initial commit Dec 3, 2021
@LovesPictures LovesPictures changed the title Ldn8 Judith Ricketts CSS Grid - Cakes Initial commit Ldn8 Judith Ricketts CSS Grid - Cakes Dec 3, 2021
@LucyMac LucyMac added the LDN-8 London class #8 (start Nov 2021) label Dec 4, 2021
Copy link

@Simon2828 Simon2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work, Jude! You've got the hang of css-grid 👏 😁

-moz-background-size: cover;
-o-background-size: cover;
background-size: cover;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try adding background-position: bottom or background-position: center to keep the cupcakes more in view 🍰 It still doesn't look 100% right... but is nearly what you want I think 😅

@LovesPictures
Copy link
Author

Thank you, Simon, background-position: bottom worked much better, I think it would also be improved with an image of the correct aspect ratio.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
LDN-8 London class #8 (start Nov 2021)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants