T50470: push websocket updates upon saving models #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knokko
force-pushed
the
T50470-simplify-websockets
branch
2 times, most recently
from
fbbb519 to
fd5c56b
Compare
knokko
force-pushed
the
T50470-simplify-websockets
branch
from
fd5c56b to
4d3eab9
Compare
|
I should look into also sending websocket updates upon bulk update/create/delete edit: done |
knokko
force-pushed
the
T50470-simplify-websockets
branch
from
4d3eab9 to
9bae7ea
Compare
knokko
force-pushed
the
T50470-simplify-websockets
branch
from
9bae7ea to
732ac4e
Compare
knokko
force-pushed
the
T50470-simplify-websockets
branch
2 times, most recently
from
bfaa447 to
af85062
Compare
viliamDokov
reviewed
Sep 18, 2025
binder/models.py
Outdated
| abstract = True | ||
| ordering = ['pk'] | ||
|
|
||
| def push_default_websocket_update(self): |
There was a problem hiding this comment.
Can this be a @classmethod It only uses self to access a class variable and the class name, no instance needed.
knokko
force-pushed
the
T50470-simplify-websockets
branch
from
af85062 to
d926e02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it very easy to automatically push websocket updates upon saving or deleting models: