fix duplication issue

Author: CodeTriangle

worlds/crosscode/types/pools.py

@@ -123,16 +123,16 @@ def __should_include(self, metadata: IncludeOptions | None) -> bool:
 
         result = True
 
-        if metadata.get("trade", False):
-            result &= self.options["trade"]
-        if metadata.get("shop", False):
-            result &= self.options["shop"]
-        if metadata.get("arena", False):
-            result &= self.options["arena"]
-        if metadata.get("chest", False):
-            result &= self.options["chest"]
-        if metadata.get("quest", False):
-            result &= self.options["quest"]
+        if metadata.get("trade", False) != self.options["trade"]:
+            result = False
+        if metadata.get("shop", False) != self.options["shop"]:
+            result = False
+        if metadata.get("arena", False) != self.options["arena"]:
+            result = False
+        if metadata.get("chest", False) != self.options["chest"]:
+            result = False
+        if metadata.get("quest", False) != self.options["quest"]:
+            result = False
 
         return result
 

worlds/crosscode/world.py

@@ -270,9 +270,6 @@ def generate_early(self):
 
         green_leaf_shade_name = "Green Leaf Shade"
 
-        self.required_items = Counter()
-        self.required_items.update(self.pools.item_pools["required"])
-
         area_unlocks = self.options.progressive_area_unlocks.value
         if area_unlocks & ProgressiveAreaUnlocks.COMBINE_POOLS:
             self.enabled_chain_names.add("areaItemsAll")