Better Handling for Annotation, Exception and Attack component by thnhmai06 · Pull Request #20 · CodeStormOOP/bounceverse

thnhmai06 · 2025-10-27T09:02:38Z

No description provided.

…h on `Attack`

Update JDK setup to use Eclipse Temurin 24

Renamed several classes and updated their package paths to improve organization (e.g., moved `AnchorPoint`, `EntityType`, and `CanExecute` to `typing.enums` and `typing.interfaces`). Updated import statements accordingly to reflect these changes.

…ling Replace RuntimeException with BounceverseException in Bounceverse.java to provide more context on errors. The new exception class allows for additional details to be passed, enhancing error reporting.

Copilot

Pull Request Overview

This PR refactors the codebase to improve annotation handling, exception management, and component compatibility checking. The changes migrate from compile-time annotation processing to runtime validation, consolidate utility classes, and reorganize the package structure for better clarity.

Key Changes:

Replaced compile-time @SuitableEntity annotation processing with runtime @ForEntity validation using new Utilities.Compatibility methods
Renamed Utils class to Utilities and reorganized package structure (data.types → typing.enums, data.contracts → typing.interfaces)
Introduced BounceverseException for game-specific error handling

Reviewed Changes

Copilot reviewed 33 out of 34 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
settings.properties	Added comment header (with encoding issues)
gradle.properties	Created new file with project metadata and comments (with encoding issues)
CanUndo.java, CanExecute.java	Moved from `data.contracts` to `typing.interfaces` and updated JavaDoc
BounceverseException.java	New custom exception class for game-specific errors
EntityType.java, DirectionUnit.java, AnchorPoint.java	Moved from `data.types` to `typing.enums` and updated JavaDoc
ForEntity.java	Changed retention policy from CLASS to RUNTIME and added compatibility checking reference
WallFactory.java, PaddleFactory.java, BallFactory.java, SceneFactory.java	Made classes final and updated imports
BrickFactory.java	Replaced `@SuitableEntity` with runtime compatibility checks and added new components
SuitableEntity.java, SuitableEntityProcessor.java	Removed annotation and processor (replaced by runtime validation)
PhysicSystem.java, InputSystem.java, SettingsManager.java, LaunchOptions.java	Updated references from `Utils` to `Utilities`
Component files (Shield.java, Attributes.java, etc.)	Updated imports for reorganized packages
Attack.java	Removed entity removal logic on zero health
Utilities.java	Renamed from `Utils` and added new `Compatibility` class with validation methods
Bounceverse.java	Updated to use `BounceverseException` instead of generic `RuntimeException`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-27T09:04:13Z

src/main/resources/settings.properties

+# ?�y ch? l� khai b�o c?a application, ch? kh�ng ph?i project.
+# N?u mu?n khai b�o project, h�y truy c?p /gradle.properties


The comment text contains encoding errors. The Vietnamese text should be properly encoded in UTF-8. The garbled characters suggest the file is being saved with incorrect encoding.

Suggested change

# ?�y ch? l� khai b�o c?a application, ch? kh�ng ph?i project.

# N?u mu?n khai b�o project, h�y truy c?p /gradle.properties

# Đây chỉ là khai báo của application, chứ không phải project.

# Nếu muốn khai báo project, hãy truy cập /gradle.properties

Copilot · 2025-10-27T09:04:14Z

gradle.properties

+# ?�y ch? l� khai b�o c?a project, ch? kh�ng ph?i application.
+# N?u mu?n khai b�o application, h�y truy c?p /src/main/resources/settings.properties


The comment text contains encoding errors. The Vietnamese text should be properly encoded in UTF-8. The garbled characters suggest the file is being saved with incorrect encoding.

Suggested change

# ?�y ch? l� khai b�o c?a project, ch? kh�ng ph?i application.

# N?u mu?n khai b�o application, h�y truy c?p /src/main/resources/settings.properties

# Đây chỉ là khai báo của project, chứ không phải application.

# Nếu muốn khai báo application, hãy truy cập /src/main/resources/settings.properties

Copilot · 2025-10-27T09:04:14Z

src/main/java/com/github/codestorm/bounceverse/typing/interfaces/CanUndo.java

 *
 *
- * <h1>{@link CanUndo}</h1>
+ * <h1>%{@link CanUndo}</h1>


The JavaDoc header contains an invalid '%' character before {@link CanUndo}. This should be removed as it's not standard JavaDoc syntax.

Suggested change

* <h1>%{@link CanUndo}</h1>

* <h1>{@link CanUndo}</h1>

Copilot · 2025-10-27T09:04:14Z

src/main/java/com/github/codestorm/bounceverse/typing/interfaces/CanExecute.java

 *
 *
- * <h1>{@link CanExecute}</h1>
+ * <h1>%{@link CanExecute}</h1>


The JavaDoc header contains an invalid '%' character before {@link CanExecute}. This should be removed as it's not standard JavaDoc syntax.

Suggested change

* <h1>%{@link CanExecute}</h1>

* <h1>{@link CanExecute}</h1>

Copilot · 2025-10-27T09:04:15Z

src/main/java/com/github/codestorm/bounceverse/typing/exceptions/BounceverseException.java

+/**
+ *
+ *
+ * <h1>!{@link BounceverseException}</h1>


The JavaDoc header contains an invalid '!' character before {@link BounceverseException}. This should be removed as it's not standard JavaDoc syntax.

Suggested change

* <h1>!{@link BounceverseException}</h1>

* <h1>{@link BounceverseException}</h1>

Copilot · 2025-10-27T09:04:15Z

src/main/java/com/github/codestorm/bounceverse/typing/enums/EntityType.java

 *
 *
- * <h1>{@link EntityType}</h1>
+ * <h1>#{@link EntityType}</h1>


The JavaDoc header contains an invalid '#' character before {@link EntityType}. This should be removed as it's not standard JavaDoc syntax.

Suggested change

* <h1>#{@link EntityType}</h1>

* <h1>{@link EntityType}</h1>

Copilot · 2025-10-27T09:04:15Z

src/main/java/com/github/codestorm/bounceverse/typing/enums/DirectionUnit.java

 *
 *
- * <h1>{@link DirectionUnit}</h1>
+ * <h1>#{@link DirectionUnit}</h1>


The JavaDoc header contains an invalid '#' character before {@link DirectionUnit}. This should be removed as it's not standard JavaDoc syntax.

Suggested change

* <h1>#{@link DirectionUnit}</h1>

* <h1>{@link DirectionUnit}</h1>

Copilot · 2025-10-27T09:04:16Z

src/main/java/com/github/codestorm/bounceverse/typing/enums/AnchorPoint.java

 *
 *
- * <h1>{@link AnchorPoint}</h1>
+ * <h1>#{@link AnchorPoint}</h1>


The JavaDoc header contains an invalid '#' character before {@link AnchorPoint}. This should be removed as it's not standard JavaDoc syntax.

Suggested change

* <h1>#{@link AnchorPoint}</h1>

* <h1>{@link AnchorPoint}</h1>

Copilot · 2025-10-27T09:04:16Z

src/main/java/com/github/codestorm/bounceverse/Utilities.java

+                }
+                throw new IllegalArgumentException(
+                        String.format(
+                                "Class '%s' does not compatible for entity has '%s' type.",


Grammatical error in the error message. Should be "is not compatible" instead of "does not compatible".

Suggested change

"Class '%s' does not compatible for entity has '%s' type.",

"Class '%s' is not compatible for entity has '%s' type.",

thnhmai06 added 5 commits October 22, 2025 17:57

[skip ci] chore: remove /system/ ignore folder

07bfda0

feat(Factory): use HealthDeath component instead of manual set deat…

74d861c

…h on `Attack`

Merge pull request #18 from CodeStormOOP/main

3e70c23

Update JDK setup to use Eclipse Temurin 24

feat(exception): introduce BounceverseException for better error hand…

1ee601b

…ling Replace RuntimeException with BounceverseException in Bounceverse.java to provide more context on errors. The new exception class allows for additional details to be passed, enhancing error reporting.

Copilot AI review requested due to automatic review settings October 27, 2025 09:02

thnhmai06 self-assigned this Oct 27, 2025

thnhmai06 merged commit 84b0b3d into main Oct 27, 2025
18 checks passed

Copilot AI reviewed Oct 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Better Handling for Annotation, Exception and Attack component#20

Better Handling for Annotation, Exception and Attack component#20
thnhmai06 merged 5 commits intomainfrom
dev

thnhmai06 commented Oct 27, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		# ?�y ch? l� khai b�o c?a application, ch? kh�ng ph?i project.
		# N?u mu?n khai b�o project, h�y truy c?p /gradle.properties

		# ?�y ch? l� khai b�o c?a project, ch? kh�ng ph?i application.
		# N?u mu?n khai b�o application, h�y truy c?p /src/main/resources/settings.properties

	* <h1>!{@link BounceverseException}</h1>
	* <h1>{@link BounceverseException}</h1>

	* <h1>#{@link DirectionUnit}</h1>
	* <h1>{@link DirectionUnit}</h1>

	* <h1>#{@link AnchorPoint}</h1>
	* <h1>{@link AnchorPoint}</h1>

	"Class '%s' does not compatible for entity has '%s' type.",
	"Class '%s' is not compatible for entity has '%s' type.",

Comments

Conversation

thnhmai06 commented Oct 27, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant