Cleaned up the error specs, increased rcov to 100%

Author: dbalatero

Rakefile

@@ -28,6 +28,7 @@ Spec::Rake::SpecTask.new(:rcov) do |spec|
   spec.libs << 'lib' << 'spec'
   spec.pattern = 'spec/**/*_spec.rb'
   spec.rcov = true
+  spec.rcov_opts = ['--exclude', 'spec']
 end
 
 task :spec => :check_dependencies

spec/alchemy_api/base_spec.rb

@@ -0,0 +1,62 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe AlchemyApi::Base do
+  describe "#check_json_for_errors_and_raise!" do
+    before(:each) do
+      @json = {
+        'status' => 'ERROR',
+        'url' => 'http://google.com',
+        'statusInfo' => nil # replace in each test.
+      }
+    end
+
+    it "should raise an error if the API key is invalid" do
+      @json['statusInfo'] = 'invalid-api-key'
+      lambda {
+        AlchemyApi::Base.check_json_for_errors_and_raise!(@json)
+      }.should raise_error(AlchemyApi::InvalidApiKeyError)
+    end
+
+    it "should raise an error if the page is not retrievable" do
+      @json['statusInfo'] = 'cannot-retrieve'
+      lambda {
+        AlchemyApi::Base.check_json_for_errors_and_raise!(@json)
+      }.should raise_error(AlchemyApi::CannotRetrieveUrlError)
+    end
+
+    it "should raise an error if the page is not valid HTML" do
+      @json['statusInfo'] = 'page-is-not-html'
+      lambda {
+        AlchemyApi::Base.check_json_for_errors_and_raise!(@json)
+      }.should raise_error(AlchemyApi::PageIsNotValidHtmlError)
+    end
+
+    it "should raise an error if the sent HTML was not valid" do
+      @json['statusInfo'] = 'invalid-html'
+      lambda {
+        AlchemyApi::Base.check_json_for_errors_and_raise!(@json)
+      }.should raise_error(AlchemyApi::InvalidHtmlError)
+    end
+
+    it "should raise an error if the content exceeds the max limit" do
+      @json['statusInfo'] = 'content-exceeds-size-limit'
+      lambda {
+        AlchemyApi::Base.check_json_for_errors_and_raise!(@json)
+      }.should raise_error(AlchemyApi::ContentExceedsMaxLimitError)
+    end
+
+    it "should raise an error if the content cannot be retrieve due to redirection limit" do
+      @json['statusInfo'] = 'cannot-retrieve:http-redirect-limit'
+      lambda {
+        AlchemyApi::Base.check_json_for_errors_and_raise!(@json)
+      }.should raise_error(AlchemyApi::RedirectionLimitError)
+    end
+
+    it "should raise an UnknownError if we get something we don't recognize" do
+      @json['statusInfo'] = 'fdsafdsfdsafdskjldklfdad'
+      lambda {
+        AlchemyApi::Base.check_json_for_errors_and_raise!(@json)
+      }.should raise_error(AlchemyApi::UnknownError)
+    end
+  end
+end

spec/alchemy_api/text_extraction_spec.rb

@@ -1,66 +1,6 @@
 require File.dirname(__FILE__) + "/../spec_helper"
 
 describe AlchemyApi::TextExtraction do
-  shared_examples_for 'error handler' do
-    before(:each) do
-      @response = mock('response')
-      @response.stub!(:code).and_return(200)
-      @json = {
-        'status' => 'ERROR',
-        'url' => 'http://google.com',
-        'statusInfo' => nil # replace in each test.
-      }
-    end
-
-    it "should raise an error if the API key is invalid" do
-      @json['statusInfo'] = 'invalid-api-key'
-      @response.stub!(:body).and_return(@json.to_json)
-      lambda {
-        AlchemyApi::TextExtraction.send(@method, @response)
-      }.should raise_error(AlchemyApi::InvalidApiKeyError)
-    end
-
-    it "should raise an error if the page is not retrievable" do
-      @json['statusInfo'] = 'cannot-retrieve'
-      @response.stub!(:body).and_return(@json.to_json)
-      lambda {
-        AlchemyApi::TextExtraction.send(@method, @response)
-      }.should raise_error(AlchemyApi::CannotRetrieveUrlError)
-    end
-
-    it "should raise an error if the page is not valid HTML" do
-      @json['statusInfo'] = 'page-is-not-html'
-      @response.stub!(:body).and_return(@json.to_json)
-      lambda {
-        AlchemyApi::TextExtraction.send(@method, @response)
-      }.should raise_error(AlchemyApi::PageIsNotValidHtmlError)
-    end
-
-    it "should raise an error if the sent HTML was not valid" do
-      @json['statusInfo'] = 'invalid-html'
-      @response.stub!(:body).and_return(@json.to_json)
-      lambda {
-        AlchemyApi::TextExtraction.send(@method, @response)
-      }.should raise_error(AlchemyApi::InvalidHtmlError)
-    end
-
-    it "should raise an error if the content exceeds the max limit" do
-      @json['statusInfo'] = 'content-exceeds-size-limit'
-      @response.stub!(:body).and_return(@json.to_json)
-      lambda {
-        AlchemyApi::TextExtraction.send(@method, @response)
-      }.should raise_error(AlchemyApi::ContentExceedsMaxLimitError)
-    end
-
-    it "should raise an error if the content cannot be retrieve due to redirection limit" do
-      @json['statusInfo'] = 'cannot-retrieve:http-redirect-limit'
-      @response.stub!(:body).and_return(@json.to_json)
-      lambda {
-        AlchemyApi::TextExtraction.send(@method, @response)
-      }.should raise_error(AlchemyApi::RedirectionLimitError)
-    end
-  end
-
   typhoeus_spec_cache('spec/cache/text_extraction/get_text_from_url') do |hydra|
     describe "#get_text_from_url" do
       it "should extract text" do
@@ -151,24 +91,4 @@
       end
     end
   end
-
-
-  describe "#get_title_from_url_handler" do
-    describe "error handling" do
-      before(:each) do
-        @method = :get_title_from_url_handler
-      end
-
-      it_should_behave_like 'error handler'
-    end
-  end
-
-  describe "#get_text_from_url_handler" do
-    describe "error handling" do
-      before(:each) do
-        @method = :get_text_from_url_handler
-      end
-      it_should_behave_like 'error handler'
-    end
-  end
 end

spec/spec_helper.rb

@@ -4,6 +4,8 @@
 require 'spec'
 require 'spec/autorun'
 
+AlchemyApi.api_key = '3468d2194732163c69b0ac76079ca9f9c4193226'
+
 require 'typhoeus_spec_cache'
 
 Spec::Runner.configure do |config|