fix: handle null values in Arrays.equal/compare hooks #1017
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`null` arrays would crash in the `Arrays.equal` and `Arrays.compare` hooks.
simonresch
force-pushed
the
fix-segfault-on-null-array
branch
from
97c492d to
c1609a3
Compare
oetr
reviewed
Nov 24, 2025
| if (returnValue) return; | ||
| byte[] first = (byte[]) arguments[0]; | ||
| byte[] second = (byte[]) arguments[1]; | ||
| if (first == null || second == null) return; |
Contributor
There was a problem hiding this comment.
For a minute I was thinking that maybe this might be worth a try:
TraceDataFlowNativeCallbacks.traceMemcmp(first != null ? first : new byte[0] , second != null ? second : new byte[0], 1, hookId);But then I remembered, that randomly inserting strings (without knowing where to insert, because one arg has no data) is almost worthless, so it's best to just exit, like you do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullarrays would crash in theArrays.equalandArrays.comparehooks.