-
Notifications
You must be signed in to change notification settings - Fork 12
[WIP] [#262] Choose a model and prompt #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sahilds1
wants to merge
32
commits into
CodeForPhilly:listOfMed
Choose a base branch
from
sahilds1:262-choose-a-model-and-prompt
base: listOfMed
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] [#262] Choose a model and prompt #306
sahilds1
wants to merge
32
commits into
CodeForPhilly:listOfMed
from
sahilds1:262-choose-a-model-and-prompt
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahilds1
commented
Jun 19, 2025
@@ -2,7 +2,7 @@ | |||
|
|||
import fitz | |||
|
|||
from server.api.services.openai_services import openAIServices | |||
from ...services.openai_services import openAIServices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: #301 (comment)
… and improved defaults evaluation/evals.py: Removed unused Reference column from input requirements and function signature. Added TODOs to improve flexibility and support defaults for instructions. Suggested running the script with uv for dependency management. llm_services.py: Refactored GPT41NanoHandler: Moved long prompt instructions into a class-level INSTRUCTIONS string. Simplified and cleaned up the handle_request method. Added default fallback behavior: uses INSTRUCTIONS if no query is provided. Removed duplicate and commented-out prompt scaffolding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.