Merge Trailing Line on Attachments, Select Attachments #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoolwinter
changed the title
thecoolwinter
requested review from
austincondiff,
0xWDG,
FastestMolasses and
tom-ludwig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug with text attachments that ended on the newline character in a line. Eg:
Text attachment added for range (0..<2) should result in:
Right now it results in the following visible lines.
Also introduces the ability for text attachments to respond to being selected and draw their contents differently.
Related Issues
Checklist
Screenshots
With new behavior:
Screen.Recording.2025-06-03.at.10.15.54.AM.mov