-
Notifications
You must be signed in to change notification settings - Fork 17
Added scroll past end behavior (overscroll) #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This works well, but I should mention we already implement overscroll in CodeEditSourceEditor. Personally, I don't think this package is the place for it. In my mind this |
The implementation in CodeEditSourceEditor is a little buggy (jumps around sometimes) and it doesn't allow the user to click in the extended area to set the cursor to the end of the file. Is there a known fix for this? If so I can implement it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spoke with Austin about this the other day, and if this gets merged, I’d like to have a direct implementation in Settings where the user can choose the overflow amount.
Everything else looks fine to me.
Awesome, I do have this PR ready to go that edits the overflow amount in the settings menu: CodeEditApp/CodeEdit#2010 It can be reviewed and merged now, but it will use the current implementation. Depends on what we want to do here, I do find the current implementation to be a bit buggy though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
Added optional functionality to allow the user to scroll past the end of the document, like in Xcode or VSCode.
Related Issues
Closes #76
Checklist
Screenshots
This is showing an extra 50% of the available screen. It will properly update when resizing the window as well.
Screen.Recording.2025-03-30.at.4.58.39.PM.mov