Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: CodeEditApp/CodeEditSourceEditor
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.15.1
Choose a base ref
...
head repository: CodeEditApp/CodeEditSourceEditor
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.15.2
Choose a head ref
  • 1 commit
  • 14 files changed
  • 1 contributor

Commits on Aug 27, 2025

  1. Suggestion Window Fixes (#350)

    ### Description
    
    Generally improves a few UX bugs with the suggestion window.
    Specifically the window would flash often even if the controller did not
    re-request new items, and would sometimes move the window when it
    shouldn't have. Also adjusts the window's x position to align the
    completion labels with the text.
    
    - Centralizes suggestion presentation logic into a single class.
    - Moves the trigger character logic out of a filter and into a textview
    delegate-like method that checks if the last typed character was a
    trigger character.
    - Ensures the textview and cursor positions are up-to-date when the
    notification is sent.
    - Helps remove duplicate cursor update notifications sent to the
    suggestion controller by checking if an update is a duplicate in the
    centralized logic controller.
    - Adjusts the suggestion window's x position to align the text in the
    completion labels with the text being typed.
    
    Also includes a few changes fixing some build warnings.
    
    ### Related Issues
    
    * #282 
    
    ### Checklist
    
    - [x] I read and understood the [contributing
    guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md)
    as well as the [code of
    conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
    - [x] The issues this PR addresses are related to each other
    - [x] My changes generate no new warnings
    - [x] My code builds and runs on my machine
    - [x] My changes are all related to the related issue above
    - [x] I documented my code
    
    ### Screenshots
    
    
    https://github.com/user-attachments/assets/14662210-0c15-422d-8dea-a5ae55b5d836
    thecoolwinter authored Aug 27, 2025
    Configuration menu
    Copy the full SHA
    424453d View commit details
    Browse the repository at this point in the history
Loading