Remove Atomic Property Wrapper

Atomic property wrapper setters just don't work. Swift grabs the value (with the lock) and then does the operation and then sets the value. There's a small time where the critical section is not protected so we need a class.

Author: thecoolwinter

Sources/CodeEditSourceEditor/TreeSitter/Atomic.swift

@@ -8,21 +8,21 @@
 import Foundation
 
 /// A simple atomic value using `NSLock`.
-@propertyWrapper
 final package class Atomic<T> {
     private let lock: NSLock = .init()
-    private var _wrappedValue: T
+    private var wrappedValue: T
 
-    package var wrappedValue: T {
-        get {
-            return lock.withLock { _wrappedValue }
-        }
-        set {
-            lock.withLock { _wrappedValue = newValue }
+    init(_ wrappedValue: T) {
+        self.wrappedValue = wrappedValue
+    }
+
+    func mutate(_ handler: (inout T) -> Void) {
+        lock.withLock {
+            handler(&wrappedValue)
         }
     }
 
-    package init(wrappedValue: T) {
-        self._wrappedValue = wrappedValue
+    func value() -> T {
+        lock.withLock { wrappedValue }
     }
 }

Sources/CodeEditSourceEditor/TreeSitter/TreeSitterClient+Edit.swift

@@ -19,7 +19,7 @@ extension TreeSitterClient {
     /// - Returns: The set of ranges invalidated by the edit operation.
     func applyEdit(edit: InputEdit) -> IndexSet {
         guard let state = state?.copy(), let readBlock, let readCallback else { return IndexSet() }
-        let pendingEdits = pendingEdits // Grab pending edits.
+        let pendingEdits = pendingEdits.value() // Grab pending edits.
         let edits = pendingEdits + [edit]
 
         var invalidatedRanges = IndexSet()
@@ -61,7 +61,9 @@ extension TreeSitterClient {
         if Task.isCancelled { return IndexSet() }
 
         self.state = state // Apply the copied state
-        self.pendingEdits = [] // Clear the queue
+        self.pendingEdits.mutate { edits in // Clear the queue
+            edits = []
+        }
 
         return invalidatedRanges
     }

Sources/CodeEditSourceEditor/TreeSitter/TreeSitterClient.swift

@@ -49,7 +49,7 @@ public final class TreeSitterClient: HighlightProviding {
     /// The end point of the previous edit.
     private var oldEndPoint: Point?
 
-    @Atomic package var pendingEdits: [InputEdit] = []
+    package var pendingEdits: Atomic<[InputEdit]> = Atomic([])
 
     /// Optional flag to force every operation to be done on the caller's thread.
     var forceSyncOperation: Bool = false
@@ -168,7 +168,9 @@ public final class TreeSitterClient: HighlightProviding {
                 priority: .edit,
                 operation: operation,
                 onCancel: { [weak self] in
-                    self?.pendingEdits.append(edit)
+                    self?.pendingEdits.mutate { edits in
+                        edits.append(edit)
+                    }
                     DispatchQueue.dispatchMainIfNot {
                         completion(.failure(HighlightProvidingError.operationCancelled))
                     }