Skip to content

"Close Tabs to the Right" no longer closes the tab the action is performed on #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

LeonardoLarranaga
Copy link
Contributor

@LeonardoLarranaga LeonardoLarranaga commented Oct 12, 2024

Description

Currently, CodeEdit closes the tab where "Close Tabs to the Right" was used on, this doesn't happen in Xcode.

Edit made: Just starts deleting from index + 1, verifying the index + 1 exists.

(Also maybe we could add a close tabs to the left? I find myself in situations where it would be incredibly useful, although it doesn't exist in Xcode).

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before:

Screen.Recording.2024-10-11.at.19.14.49.mov

After:

Screen.Recording.2024-10-11.at.19.21.52.mov

@LeonardoLarranaga LeonardoLarranaga changed the title Fixes an issue where "Close Tabs to the Right" would also close the tab the action was performed on. Fixes an issue where "Close Tabs to the Right" would also close the tab the action was performed on Oct 12, 2024
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@austincondiff austincondiff changed the title Fixes an issue where "Close Tabs to the Right" would also close the tab the action was performed on "Close Tabs to the Right" no longer closes the tab the action is performed on Oct 12, 2024
@austincondiff
Copy link
Collaborator

One minor thing I notice is the tabs fade out when closed. In Xcode they do not.

Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austincondiff austincondiff merged commit cb2fdb2 into CodeEditApp:main Oct 12, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants