Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quicklook Previews in Open Quickly overlay #1266

Merged
merged 5 commits into from
May 16, 2023
Merged

Quicklook Previews in Open Quickly overlay #1266

merged 5 commits into from
May 16, 2023

Conversation

luah5
Copy link
Member

@luah5 luah5 commented May 14, 2023

Description

this PR adds support for Quicklook Previews in the Open Quickly Overlay using OtherFileView. In addition, this PR extends URL to check whether or not the file is supported by OtherFileView.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

shot.2.mov

@luah5 luah5 requested a review from RayZhao1998 May 14, 2023 15:29
RayZhao1998
RayZhao1998 previously approved these changes May 14, 2023
View reviewed changes
Copy link
Collaborator

@RayZhao1998 RayZhao1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

austincondiff
austincondiff requested changes May 14, 2023
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One small change though. For images smaller than the viewable area, they should show actual pixel size rather than filling the container. Users can always zoom in by pinching to zoom if they need to.

@luah5
Copy link
Member Author

luah5 commented May 15, 2023

I won't be able to work on this for a bit of time, so I've allowed maintainers+ edit access incase of another issue.

@luah5 luah5 requested a review from RayZhao1998 May 16, 2023 05:26
@luah5 luah5 marked this pull request as draft May 16, 2023 05:26
@austincondiff austincondiff marked this pull request as ready for review May 16, 2023 14:46
@austincondiff austincondiff merged commit 1454828 into CodeEditApp:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

@RayZhao1998 RayZhao1998 RayZhao1998 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ QuickLook previews in quickly open overlay
3 participants
@luah5 @austincondiff @RayZhao1998