Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Italian language #20

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Update Italian language #20

merged 1 commit into from
Mar 25, 2024

Conversation

bovirus
Copy link
Contributor

@bovirus bovirus commented Mar 22, 2024

@CodeDead

Please merge. Thanks.

@CodeDead
Copy link
Owner

Thanks for the translations. How can we credit you for your good work? We can add your name and a link of your choosing to the about screen and credits in the README file in this repository OR we can also let you remain anonymous if you want. Please let me know before I merge this.

@CodeDead CodeDead self-assigned this Mar 23, 2024
@CodeDead CodeDead added the translation Application translations label Mar 23, 2024
@CodeDead CodeDead changed the base branch from master to development March 23, 2024 09:54
@bovirus
Copy link
Contributor Author

bovirus commented Mar 25, 2024

@CodeDead

Please add my nick bovirus.
I didn't have a web page to add to the credits
If you think could eb sueful to report problem about Italian language you can add my email bovirus at gmail . com

@CodeDead CodeDead changed the base branch from development to feature/italian March 25, 2024 15:26
@CodeDead CodeDead merged commit 25540e8 into CodeDead:feature/italian Mar 25, 2024
@CodeDead
Copy link
Owner

CodeDead commented Mar 25, 2024

Thanks @bovirus ! We've included your changes and made them available in the app. You have been given credits in the README and also in the application's information screen!

https://github.com/CodeDead/Advanced-PortChecker/tree/development

Thanks for making the application more accessible for Italian users!

@bovirus
Copy link
Contributor Author

bovirus commented Mar 25, 2024

@CodeDead

I will add to the readme the info about other languages available

Dutch
French
Spanish

@CodeDead
Copy link
Owner

@bovirus no need, this information will be discarded since it is redundant to credit CodeDead

@bovirus
Copy link
Contributor Author

bovirus commented Mar 25, 2024

@CodeDead

No klist of languages for credit.
List of languages available as application specfication.
If a dutch/spanish/french user read readme didn't find info that language for this conuntries are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Application translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants