Status appIcon no longer shown

[RobinDaugherty]

Not sure when, but several macOS versions ago, the app icon is forced to be the actual app icon. Only contentImage has any effect now.

But as of df82582 the appIcon and contentImage options were switched, making all guard notifications look the same:

["/opt/rbenv/versions/2.7.2/bin/terminal-notifier",
 "-title",
 "RSpec results",
 "-priority",
 "-2",
 "-message",
 "2 examples, 0 failures in 0.0185 seconds",
 "-contentImage",
 "/opt/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/terminal-notifier-guard-1.7.0/icons/Guard.icns",
 "-appIcon",
 "/opt/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/terminal-notifier-guard-1.7.0/icons/Success.icns"]

["/opt/rbenv/versions/2.7.2/bin/terminal-notifier",
 "-title",
 "RSpec results",
 "-priority",
 "-2",
 "-message",
 "2 examples, 2 failures in 1.1234 seconds",
 "-contentImage",
 "/opt/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/terminal-notifier-guard-1.7.0/icons/Guard.icns",
 "-appIcon",
 "/opt/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/terminal-notifier-guard-1.7.0/icons/Failed.icns"]

This is obviously unfortunate. I think it's been broken for at least a year.

I think the solution is to just swap appIcon and contentImage back to the way they were, along with a major version bump, so people sticking with older macOS versions can just lock to the old version.

An alternative is to include unicode characters in the message content/subtitle to indicate success/failure.

[gorodulin]

Please review&merge @lanej0's PR 🙏🏻

[dsnovaes]

Any solution to this yet?