Skip to content

Remove default features from statrs #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

konstin
Copy link
Contributor

@konstin konstin commented Jun 30, 2025

statrs pulls in a number of transitive dependencies by default, which seem not to be required.

statrs pulls in a number of transitive dependencies by default, which seem not to be required.
Copy link

codspeed-hq bot commented Jun 30, 2025

CodSpeed Instrumentation Performance Report

Merging #108 will degrade performances by 8.37%

Comparing konstin:konsti/statrs-less-deps (95e687a) with main (5b72e17)

Summary

⚡ 22 improvements
❌ 5 regressions
✅ 140 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
Iterative 191.7 ns 162.5 ns +17.95%
Iterative[20] 191.7 ns 162.5 ns +17.95%
Iterative[21] 193.3 ns 164.2 ns +17.77%
sleep_100ms 595.3 ns 624.4 ns -4.67%
sleep_10ms 595.3 ns 624.4 ns -4.67%
sleep_1ms 566.1 ns 595.3 ns -4.9%
sleep_50ms 566.1 ns 595.3 ns -4.9%
bench_array1[10] 254.2 ns 225 ns +12.96%
bench_array2[10] 254.2 ns 225 ns +12.96%
mut_borrow 924.2 ns 895 ns +3.26%
recursive[0] 240.3 ns 211.1 ns +13.82%
recursive[5] 320.3 ns 291.1 ns +10.02%
recursive_memoized[HashMap<u64, u64>, 0] 958.3 ns 1,045.8 ns -8.37%
count_set_bits[0] 119.2 ns 90 ns +32.41%
count_set_bits[1024] 120.8 ns 91.7 ns +31.82%
count_set_bits[255] 128.6 ns 99.4 ns +29.33%
count_set_bits[42] 123.1 ns 93.9 ns +31.07%
count_set_bits[65535] 137.5 ns 108.3 ns +26.92%
find_highest_set_bit[1024] 121.1 ns 91.9 ns +31.72%
find_highest_set_bit[255] 121.1 ns 91.9 ns +31.72%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@art049 art049 merged commit 11950a0 into CodSpeedHQ:main Jun 30, 2025
12 of 13 checks passed
Copy link

codspeed-hq bot commented Jun 30, 2025

CodSpeed WallTime Performance Report

Merging #108 will degrade performances by 46.22%

Comparing konstin:konsti/statrs-less-deps (95e687a) with main (5b72e17)

Summary

⚡ 19 improvements
❌ 15 regressions
✅ 120 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
build_vec 204 ns 211 ns -3.32%
Iterative 21 ns 20 ns +5%
Iterative[20] 21 ns 20 ns +5%
Iterative[21] 22 ns 21 ns +4.76%
large_drop 167.3 µs 178.7 µs -6.37%
large_setup 14 ns 15 ns -6.67%
iter_with_setup 36 ns 40 ns -10%
from_elem[2048] 226 ns 243 ns -7%
from_elem[4096] 324 ns 336 ns -3.57%
from_elem_decimal[2048] 252 ns 211 ns +19.43%
bench_array1[10] 9 ns 10 ns -10%
bench_array1[1] 2 ns 1 ns ×2
bench_array2[10] 9 ns 10 ns -10%
bench_array2[1] 2 ns 1 ns ×2
iterative[5] 7 ns 8 ns -12.5%
recursive_memoized[BTreeMap<u64, u64>, 10] 578 ns 555 ns +4.14%
recursive_memoized[BTreeMap<u64, u64>, 20] 1.9 µs 1.8 µs +5.41%
recursive_memoized[BTreeMap<u64, u64>, 5] 225 ns 198 ns +13.64%
recursive_memoized[HashMap<u64, u64>, 10] 1.6 µs 1.5 µs +4.5%
recursive_memoized[HashMap<u64, u64>, 5] 591 ns 573 ns +3.14%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

konstin added a commit to astral-sh/uv that referenced this pull request Jul 1, 2025
zanieb pushed a commit to astral-sh/uv that referenced this pull request Jul 1, 2025
ntBre added a commit to astral-sh/ruff that referenced this pull request Jul 1, 2025
Summary
--

Updates to codspeed 3.0.2, removing some of the new dependencies introduced in
3.0. See astral-sh/uv#14396 and
CodSpeedHQ/codspeed-rust#108 for the similar PR in uv
and the upstream fix, respectively.

Test Plan
--

N/a
ntBre added a commit to astral-sh/ruff that referenced this pull request Jul 1, 2025
Summary
--

Updates to codspeed 3.0.2, removing some of the new dependencies
introduced in 3.0. See astral-sh/uv#14396 and
CodSpeedHQ/codspeed-rust#108 for the similar PR
in uv and the upstream fix, respectively.

Test Plan
--

N/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants