Skip to content

Fix build on windows #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Fix build on windows #106

merged 1 commit into from
Jun 30, 2025

Conversation

adriencaccia
Copy link
Member

Fix #105

Copy link

codspeed-hq bot commented Jun 30, 2025

CodSpeed Instrumentation Performance Report

Merging #106 will degrade performances by 6.78%

Comparing fix/windows-build (6f3aa29) with main (96317b0)

Summary

⚡ 5 improvements
❌ 11 regressions
✅ 151 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
sleep_100ms 595.3 ns 624.4 ns -4.67%
sleep_10ms 566.1 ns 595.3 ns -4.9%
sleep_1ms 566.1 ns 595.3 ns -4.9%
sleep_50ms 566.1 ns 595.3 ns -4.9%
bench_array1[4] 183.6 ns 154.4 ns +18.88%
bench_array2[4] 183.6 ns 154.4 ns +18.88%
init_array[4] 183.6 ns 154.4 ns +18.88%
mut_borrow 895 ns 924.2 ns -3.16%
recursive[0] 240.3 ns 211.1 ns +13.82%
recursive[5] 320.3 ns 291.1 ns +10.02%
recursive_memoized[BTreeMap<u64, u64>, 0] 400.8 ns 430 ns -6.78%
sleep_100ns 536.9 ns 566.1 ns -5.15%
sleep_100us 536.9 ns 566.1 ns -5.15%
sleep_1ms 536.9 ns 566.1 ns -5.15%
sleep_1ns 536.9 ns 566.1 ns -5.15%
sleep_1us 536.9 ns 566.1 ns -5.15%

Copy link

codspeed-hq bot commented Jun 30, 2025

CodSpeed WallTime Performance Report

Merging #106 will degrade performances by 47.63%

Comparing fix/windows-build (6f3aa29) with main (96317b0)

Summary

⚡ 13 improvements
❌ 11 regressions
✅ 130 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
large_setup 16 ns 13 ns +23.08%
from_elem[1024] 82 ns 79 ns +3.8%
from_elem[4096] 330 ns 288 ns +14.58%
from_elem_decimal[1024] 82 ns 79 ns +3.8%
bench_array1[10] 10 ns 9 ns +11.11%
bench_array2[10] 10 ns 9 ns +11.11%
print_env_hello 2.1 µs 2.2 µs -3.89%
generate_combinations[6] 1.3 µs 1.3 µs +4.72%
generate_parentheses[4] 7.2 µs 6.9 µs +4.7%
graph_coloring[3] 1 µs 1.1 µs -8.52%
graph_coloring[5] 1,019 ns 977 ns +4.3%
hamiltonian_cycle[5] 687 ns 654 ns +5.05%
permutations[5] 11.1 µs 13.7 µs -19.14%
subset_sum[16] 3.9 µs 4 µs -3.29%
add_two_integers[(42, 13)] 19 ns 6 ns ×3.2
count_set_bits[0] 7 ns 8 ns -12.5%
count_set_bits[1024] 7 ns 8 ns -12.5%
count_set_bits[255] 7 ns 8 ns -12.5%
count_set_bits[42] 7 ns 8 ns -12.5%
count_set_bits[65535] 7 ns 8 ns -12.5%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@art049 art049 merged commit 6f3aa29 into main Jun 30, 2025
11 of 14 checks passed
@art049 art049 deleted the fix/windows-build branch June 30, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codspeed 3.0.0 doesn't compile on windows
2 participants