fix(criterion_fork): fix assertion failed: !(range.0.is_nan() || range.1.is_nan()) error

Author: GuillaumeLagrange

crates/criterion_compat/criterion_fork/src/plot/gnuplot_backend/summary.rs

@@ -65,10 +65,14 @@ pub fn line_comparison(
 
     let mut i = 0;
 
+    // CODSPEED FIX: Changed from fold(::std::f64::NAN, f64::max) to fold(0.0, f64::max)
+    // and added filter(|x| x.is_finite()) to prevent NaN propagation. See the same fix
+    // in plotters_backend/summary.rs for detailed explanation.
     let max = all_curves
         .iter()
         .map(|&(_, data)| Sample::new(data).mean())
-        .fold(::std::f64::NAN, f64::max);
+        .filter(|x| x.is_finite())
+        .fold(0.0, f64::max);
 
     let mut dummy = [1.0];
     let unit = formatter.scale_values(max, &mut dummy);

crates/criterion_compat/criterion_fork/src/plot/plotters_backend/summary.rs

@@ -118,10 +118,19 @@ fn line_comparison_series_data<'a>(
     formatter: &dyn ValueFormatter,
     all_curves: &[&(&'a BenchmarkId, Vec<f64>)],
 ) -> (&'static str, Vec<(Option<&'a String>, Vec<f64>, Vec<f64>)>) {
+    // CODSPEED FIX: Changed from fold(::std::f64::NAN, f64::max) to fold(0.0, f64::max)
+    // and added filter(|x| x.is_finite()) to prevent NaN propagation.
+    //
+    // Previously, starting the fold with NaN meant that f64::max would always return NaN
+    // (since NaN comparisons always return false). This caused plotters to panic with
+    // "assertion failed: !(range.0.is_nan() || range.1.is_nan())" when trying to create
+    // plot ranges. This was particularly problematic with very small measurements (picoseconds)
+    // and high outlier percentages, which could occur intermittently in CI.
     let max = all_curves
         .iter()
         .map(|&(_, data)| Sample::new(data).mean())
-        .fold(::std::f64::NAN, f64::max);
+        .filter(|x| x.is_finite())
+        .fold(0.0, f64::max);
 
     let mut dummy = [1.0];
     let unit = formatter.scale_values(max, &mut dummy);
@@ -166,8 +175,14 @@ pub fn violin(
         .map(|&&(id, ref sample)| {
             let (x, mut y) = kde::sweep(Sample::new(sample), KDE_POINTS, None);
             let y_max = Sample::new(&y).max();
-            for y in y.iter_mut() {
-                *y /= y_max;
+            // CODSPEED FIX: Only normalize if y_max is finite and non-zero to prevent
+            // division by zero or NaN propagation. Previously, dividing by y_max without
+            // checking could produce Inf or NaN values if y_max was 0.0 or non-finite,
+            // which would cause plotters to panic when creating plot ranges.
+            if y_max.is_finite() && y_max > 0.0 {
+                for y in y.iter_mut() {
+                    *y /= y_max;
+                }
             }
 
             (id.as_title(), x, y)