-
Notifications
You must be signed in to change notification settings - Fork 1
Fix for reported LiteBeam signal in Disconnected #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated version to 0.4.4, adjusted CHANGELOG entries, and made the Disconnected.signal field optional (int | None = None) and repositioned it after airos_connected in airos/data.py. No exported/public API signatures changed aside from the field’s optionality. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
|
As reported home-assistant/core#151145 (comment) (own issue pending) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 91.36% 91.36%
=======================================
Files 4 4
Lines 730 730
=======================================
Hits 667 667
Misses 63 63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CHANGELOG.md (1)
17-22: Fix 0.4.2 changelog entry inconsistency
The “Aligned quality targets either improved or tagged” bullet remains in CHANGELOG.md (line 21) despite the AI summary stating it was removed. Delete this line or update the summary to match.
🧹 Nitpick comments (3)
airos/data.py (2)
405-405: Nit: fix brand capitalization in inline comment.
Change “Litebeam” → “LiteBeam” for consistency with the rest of the file.- signal: int | None = None # Litebeam 5AC can have no signal + signal: int | None = None # LiteBeam 5AC can have no signal
387-391: Docstring says “Wireless” inside Remote.pre_deserialize.
Minor copy/paste mismatch; should reference Remote.- """Pre-deserialize hook for Wireless.""" + """Pre-deserialize hook for Remote."""CHANGELOG.md (1)
15-15: Fix grammar and double space in 0.4.3 line.-- Made antenna_gain and nol_* optional as reported on Prism and LiteBeam 8.7.8 support +- Made antenna_gain and nol_* optional as reported on Prism and LiteBeam 8.7.8.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)airos/data.py(1 hunks)pyproject.toml(1 hunks)
🔇 Additional comments (3)
pyproject.toml (1)
7-7: Version bump matches CHANGELOG; LGTM.airos/data.py (1)
405-405: No downstream.signalusage detected—makingsignaloptional is safe. Please still add a test covering deserialization whensignalis absent.CHANGELOG.md (1)
5-10: 0.4.4 entry reads clearly; matches code change.



Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores