Quality

Author: CoMPaTech

airos/airos8.py

@@ -398,8 +398,7 @@ async def provmode(self, active: bool = False) -> bool:
             _LOGGER.info("Provisioning mode change task was cancelled")
             raise
 
-
-    async def warnings(self) -> dict[str, Any]:
+    async def warnings(self) -> dict[str, Any] | Any:
         """Get warnings."""
         if not self.connected:
             _LOGGER.error("Not connected, login first")
@@ -420,7 +419,7 @@ async def warnings(self) -> dict[str, Any]:
                     return json.loads(response_text)
                 log = f"Unable to fech warning status {response.status} with {response_text}"
                 _LOGGER.error(log)
-                return False
+                raise AirOSDataMissingError from None
         except json.JSONDecodeError:
             _LOGGER.exception("JSON Decode Error in warning response")
             raise AirOSDataMissingError from None
@@ -431,8 +430,7 @@ async def warnings(self) -> dict[str, Any]:
             _LOGGER.info("Warning check task was cancelled")
             raise
 
-
-    async def update_check(self) -> dict[str, Any]:
+    async def update_check(self) -> dict[str, Any] | Any:
         """Get warnings."""
         if not self.connected:
             _LOGGER.error("Not connected, login first")
@@ -455,7 +453,7 @@ async def update_check(self) -> dict[str, Any]:
                     return json.loads(response_text)
                 log = f"Unable to fech update status {response.status} with {response_text}"
                 _LOGGER.error(log)
-                return False
+                raise AirOSDataMissingError from None
         except json.JSONDecodeError:
             _LOGGER.exception("JSON Decode Error in warning response")
             raise AirOSDataMissingError from None
@@ -465,4 +463,3 @@ async def update_check(self) -> dict[str, Any]:
         except asyncio.CancelledError:
             _LOGGER.info("Warning update status task was cancelled")
             raise
-

tests/test_airos8.py

@@ -260,18 +260,24 @@ async def test_status_missing_required_key_in_json(airos_device: AirOS) -> None:
     # Assert that the cause of our exception is the correct type from mashumaro
     assert isinstance(excinfo.value.__cause__, MissingField)
 
+
 # --- Tests for warnings() and update_check() ---
 @pytest.mark.asyncio
 async def test_warnings_correctly_parses_json() -> None:
     """Test that the warnings() method correctly parses a valid JSON response."""
     mock_session = MagicMock()
-    airos_device = AirOS(host="http://192.168.1.3", username="test", password="test", session=mock_session)
+    airos_device = AirOS(
+        host="http://192.168.1.3",
+        username="test",
+        password="test",
+        session=mock_session,
+    )
     airos_device.connected = True
 
     mock_response = MagicMock()
     mock_response.__aenter__.return_value = mock_response
     mock_response.status = 200
-    with open("fixtures/warnings.json") as f:
+    with open("fixtures/warnings.json", encoding="utf-8") as f:
         mock_response_data = json.load(f)
     mock_response.text = AsyncMock(return_value=json.dumps(mock_response_data))
 
@@ -285,31 +291,43 @@ async def test_warnings_correctly_parses_json() -> None:
 async def test_warnings_raises_exception_on_invalid_json() -> None:
     """Test that warnings() raises an exception on invalid JSON response."""
     mock_session = MagicMock()
-    airos_device = AirOS(host="http://192.168.1.3", username="test", password="test", session=mock_session)
+    airos_device = AirOS(
+        host="http://192.168.1.3",
+        username="test",
+        password="test",
+        session=mock_session,
+    )
     airos_device.connected = True
 
     mock_response = MagicMock()
     mock_response.__aenter__.return_value = mock_response
     mock_response.status = 200
     mock_response.text = AsyncMock(return_value="This is not JSON")
 
-    with (patch.object(airos_device.session, "get", return_value=mock_response),
-        pytest.raises(airos.exceptions.AirOSDataMissingError)):
-            await airos_device.warnings()
+    with (
+        patch.object(airos_device.session, "get", return_value=mock_response),
+        pytest.raises(airos.exceptions.AirOSDataMissingError),
+    ):
+        await airos_device.warnings()
 
 
 @pytest.mark.asyncio
 async def test_update_check_correctly_parses_json() -> None:
     """Test that update_check() method correctly parses a valid JSON response."""
     mock_session = MagicMock()
-    airos_device = AirOS(host="http://192.168.1.3", username="test", password="test", session=mock_session)
+    airos_device = AirOS(
+        host="http://192.168.1.3",
+        username="test",
+        password="test",
+        session=mock_session,
+    )
     airos_device.connected = True
     airos_device.current_csrf_token = "mock-csrf-token"
 
     mock_response = MagicMock()
     mock_response.__aenter__.return_value = mock_response
     mock_response.status = 200
-    with open("fixtures/update_check_available.json") as f:
+    with open("fixtures/update_check_available.json", encoding="utf-8") as f:
         mock_response_data = json.load(f)
     mock_response.text = AsyncMock(return_value=json.dumps(mock_response_data))
 
@@ -323,7 +341,12 @@ async def test_update_check_correctly_parses_json() -> None:
 async def test_update_check_raises_exception_on_invalid_json() -> None:
     """Test that update_check() raises an exception on invalid JSON response."""
     mock_session = MagicMock()
-    airos_device = AirOS(host="http://192.168.1.3", username="test", password="test", session=mock_session)
+    airos_device = AirOS(
+        host="http://192.168.1.3",
+        username="test",
+        password="test",
+        session=mock_session,
+    )
     airos_device.connected = True
     airos_device.current_csrf_token = "mock-csrf-token"
 
@@ -332,16 +355,23 @@ async def test_update_check_raises_exception_on_invalid_json() -> None:
     mock_response.status = 200
     mock_response.text = AsyncMock(return_value="This is not JSON")
 
-    with (patch.object(airos_device.session, "post", return_value=mock_response),
-        pytest.raises(airos.exceptions.AirOSDataMissingError)):
-            await airos_device.update_check()
+    with (
+        patch.object(airos_device.session, "post", return_value=mock_response),
+        pytest.raises(airos.exceptions.AirOSDataMissingError),
+    ):
+        await airos_device.update_check()
 
 
 @pytest.mark.asyncio
 async def test_warnings_when_not_connected() -> None:
     """Test calling warnings() before a successful login."""
     mock_session = MagicMock()
-    airos_device = AirOS(host="http://192.168.1.3", username="test", password="test", session=mock_session)
+    airos_device = AirOS(
+        host="http://192.168.1.3",
+        username="test",
+        password="test",
+        session=mock_session,
+    )
     airos_device.connected = False  # Explicitly set connected state to false
 
     with pytest.raises(airos.exceptions.AirOSDeviceConnectionError):
@@ -352,8 +382,13 @@ async def test_warnings_when_not_connected() -> None:
 async def test_update_check_when_not_connected() -> None:
     """Test calling update_check() before a successful login."""
     mock_session = MagicMock()
-    airos_device = AirOS(host="http://192.168.1.3", username="test", password="test", session=mock_session)
-    airos_device.connected = False # Explicitly set connected state to false
+    airos_device = AirOS(
+        host="http://192.168.1.3",
+        username="test",
+        password="test",
+        session=mock_session,
+    )
+    airos_device.connected = False  # Explicitly set connected state to false
 
     with pytest.raises(airos.exceptions.AirOSDeviceConnectionError):
         await airos_device.update_check()