Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the client launcher to pass on command line arguments to the game it is launching. #471

Open
CCHyper opened this issue Jun 6, 2023 · 2 comments

Comments

@CCHyper
Copy link

CCHyper commented Jun 6, 2023

Allow the client launcher to pass on command line arguments to the game it is launching. This would allow users to create a shortcut to the main client launcher executable, and hard code these to the ClientDefintions.ini.

For example;
TiberianSun.exe -GAME_ARGS=-DEVELOPER.

Vinifera implements a new "developer" feature to assist mod creators in their process, but mod creators need to keep modifying ExtraCommandLineParams= in ClientDefintions.ini to remove this before they push their update, sometimes this is not always done and results in an update being pushed where the end users enter the developer mode and another update is required to be pushed to revert this. Support for passing on custom arguments like this via the client launcher would allow mod creators to leave ExtraCommandLineParams= untouched, and then create a local shortcut for this to run the game in the developer mode.

Open to other suggestions as to how this could be implemented.

@LeuisKen
Copy link
Contributor

LeuisKen commented Jul 4, 2024

I have a similar idea but more related to the player's perspective. #535
May be it's also okay for you to consider?

@SadPencil
Copy link
Member

I have a similar idea but more related to the player's perspective. #535 May be it's also okay for you to consider?

After quickly reviewing your PR, #535 does not solve this issue but #547 does. This is because in most cases (except for game.exe and gamemd.exe in CnCNet YR) the client lanches the game executable via StartGameProcess().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants