OCPBUGS-60098: podman-etcd: avoid leaving member list on last active agent

When stopping an etcd instance, the agent should not leave the member
list if it's the last active agent in the cluster. Leaving the member
list in this scenario can cause WAL corruption.

This change introduces a check for the number of active resources before
attempting to leave the member list. If no other active resources are
found, the agent will log a message and skip the leave operation.

NOTE: the check on `standalone_node` might not be enough if both agents
stop roughly at the same time, hence none of them has enough time to set
the attribute.

Author: clobrano

heartbeat/podman-etcd

@@ -2021,6 +2021,35 @@ podman_start()
 	done
 }
 
+leave_etcd_member_list()
+{
+	if ! member_id=$(attribute_node_member_id get); then
+		ocf_log err "error leaving members list: could not get member-id"
+		return
+	fi
+
+	if is_standalone; then
+		ocf_log info "last member. Not leaving the member list"
+		return
+	fi
+
+	local active_resources_count
+	active_resources_count=$(get_truly_active_resources_count)
+	ocf_log info "found '$active_resources_count' active etcd resources (active: '$OCF_RESKEY_CRM_meta_notify_active_resource', stop: '$OCF_RESKEY_CRM_meta_notify_stop_resource')"
+	if [ "$active_resources_count" -lt 1 ]; then
+		ocf_log info "No active agents left. Not leaving the member list"
+		return
+	fi
+	
+	ocf_log info "leaving members list as member with ID $member_id"
+	local endpoint
+	endpoint="$(ip_url $(attribute_node_ip get)):2379"
+	if ! ocf_run podman exec "$CONTAINER" etcdctl member remove "$member_id" --endpoints="$endpoint"; then
+		rc=$?
+		ocf_log err "error leaving members list, error code: $rc"
+	fi
+}
+
 podman_stop()
 {
 	local timeout=60
@@ -2035,29 +2064,15 @@ podman_stop()
 
 	attribute_node_revision update
 	attribute_node_cluster_id update
+	attribute_node_member_id clear
 
 	podman_simple_status
 	if [ $? -eq  $OCF_NOT_RUNNING ]; then
 		ocf_log info "could not leave members list: etcd container not running"
 		return $OCF_SUCCESS
 	fi
 
-	if ! member_id=$(attribute_node_member_id get); then
-		ocf_log err "error leaving members list: could not get member-id"
-	else
-		# TODO: is it worth/possible to check the current status instead than relying on cached attributes?
-		if is_standalone; then
-			ocf_log info "last member. Not leaving the member list"
-		else
-			ocf_log info "leaving members list as member with ID $member_id"
-			endpoint="$(ip_url $(attribute_node_ip get)):2379"
-			if ! ocf_run podman exec "$CONTAINER" etcdctl member remove "$member_id" --endpoints="$endpoint"; then
-				rc=$?
-				ocf_log err "error leaving members list, error code: $rc"
-			fi
-		fi
-	fi
-	attribute_node_member_id clear
+	leave_etcd_member_list
 
 	if [ -n "$OCF_RESKEY_CRM_meta_timeout" ]; then
 		timeout=$(((OCF_RESKEY_CRM_meta_timeout/1000) -10 ))