Explictly check return from lock functions #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the postgres adapter uses connection#select_value which looking at the documentation the call chain is : select_value -> select_one -> select_all select_all "... returns an array of hashes ..." select_one "... selects first hash of array ..." select_value " ... selects first value of hash ..." This means that when selecting more than one value in a statement you need to explictly request which column you want. In some Rubies maybe select_value always returns the output of the lock functions but at least in REE/MRI 1.8 and jRuby in 1.8 mode where I tested this is not true. The fix is simple - use execute and retrieve the value ( PR coming ) or change the SQL to only select the lock function result.
|
👍 |
|
Crap, I totally missed this PR. Thanks for the great explanation and the diff—it'll be in v1.1.0 that I will release tonight. |
|
Cool, thanks. I totally missed following up on this too :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the postgres adapter uses connection#select_value which looking at the documentation the call chain is :
select_value -> select_one -> select_all
select_all "... returns an array of hashes ..."
select_one "... selects first hash of array ..."
select_value " ... selects first value of hash ..."
This means that when selecting more than one value in a statement you need to explictly request which column you want.
In some Rubies maybe select_value always returns the output of the lock functions but at least in REE/MRI 1.8 and jRuby in 1.8 mode where I tested this is not true.
The fix is simple - use execute and retrieve the value ( PR coming ) or change the SQL to only select the lock function result.