Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason for major version bump to 7.x? #331

Closed
swrobel opened this issue Sep 25, 2018 · 3 comments
Closed

Reason for major version bump to 7.x? #331

swrobel opened this issue Sep 25, 2018 · 3 comments

Comments

@swrobel
Copy link
Contributor

swrobel commented Sep 25, 2018

First of all, don't get me wrong, I'm really excited about the new release, and appreciate all of the hard work that went into it...

I'm just wondering why the major version was bumped to 7. Looking at the changes from 6.6.0 to 7.0.0, there don't seem to be any breaking changes, as would be indicated by the version bump.

@mceachen
Copy link
Collaborator

mceachen commented Oct 2, 2018

Perhaps @seuros was being overly cautious? I'm not aware of breaking changes, fwiw.

@seuros
Copy link
Member

seuros commented Oct 2, 2018

@swrobel , sorry for delay.
We will always bump to a major version when supporting a new version of ActiveRecord. While support for the versions stayed the same this time. the syntax of some files changed (Some raw sqls string are now in Arel).
If there was a regression, we won't affect people that locked their version in ~> 6.6.0 while trying to fix the bug.

@mceachen
Copy link
Collaborator

mceachen commented Oct 2, 2018

sgtm, thanks for the explanation!

@mceachen mceachen closed this as completed Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants