Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5.2 #305

Closed
johan-smits opened this issue Apr 10, 2018 · 8 comments
Closed

Rails 5.2 #305

johan-smits opened this issue Apr 10, 2018 · 8 comments
Milestone

Comments

@johan-smits
Copy link

217162c you fixed #296.
Rails 5.2 is not officially released. Could you also bump/release your gem to include this fix?

@grk
Copy link
Contributor

grk commented Apr 16, 2018

For the record, #264 is also a blocker for Rails 5.2 compatibility.

@seuros seuros added this to the 7.0.0 milestone Apr 16, 2018
@n-rodriguez
Copy link
Contributor

#264 is now closed :)

@mjy
Copy link

mjy commented May 1, 2018

Are there other blocking issues that are known? What's the release pattern, do you typically fork a branch with the new environment and add it to the CI for testing?

@grk
Copy link
Contributor

grk commented May 1, 2018

I've been testing the current master for a few days and for us, everything works fine.

@mceachen
Copy link
Collaborator

@grk and @n-rodriguez could you guys check out #308 and #309 ? I'll merge that if the three of you all agree that the PR is correct.

(I'm also looking for more committers for ClosureTree!)

@n-rodriguez
Copy link
Contributor

could you guys check out #308 and #309 ?

sure

@mceachen
Copy link
Collaborator

Builds on 5.2 have been green for a while. Closing. Thanks for everyone's help. Time for v7.0.0!

@timdown
Copy link

timdown commented Jul 9, 2018

Any news on the release of 7.0.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants