-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clear table placeholders when data is empty #344
Merged
Pankraty
merged 6 commits into
ClosedXML:develop
from
smakaiberriesandco:update-closedxml
Apr 11, 2024
Merged
fix: clear table placeholders when data is empty #344
Pankraty
merged 6 commits into
ClosedXML:develop
from
smakaiberriesandco:update-closedxml
Apr 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smakaiberriesandco
changed the title
chore: update closed xml include .net 8 to target fw
chore: update ClosedXML pkg include .net 8 to target fw
Feb 1, 2024
smakaiberriesandco
changed the title
chore: update ClosedXML pkg include .net 8 to target fw
fix: update ClosedXML pkg, include .net 8 to target fw, fix empty tables
Feb 2, 2024
when generating excel from a template with an empty list it throws an exception: I updated the commit to fix that issue too. |
Pankraty
requested changes
Feb 12, 2024
# Conflicts: # tests/ClosedXML.Report.Tests/ClosedXML.Report.Tests.csproj
smakaiberriesandco
changed the title
fix: update ClosedXML pkg, include .net 8 to target fw, fix empty tables
fix: clear table placeholders when data is empty
Feb 14, 2024
Thanks for the contribution and sorry it took me so long! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#338
#343