Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vars differing only in case cause problems on case-insensitive filesystems #21

Closed
emlyn opened this issue Mar 12, 2023 · 3 comments · Fixed by #22
Closed

Vars differing only in case cause problems on case-insensitive filesystems #21

emlyn opened this issue Mar 12, 2023 · 3 comments · Fixed by #22

Comments

@emlyn
Copy link
Contributor

emlyn commented Mar 12, 2023

Having two vars that differ only in case causes issues when building a jar on case insensitive file systems, since one class file will overwrite the other. There are two pairs of names causing issues, both in the clojure2d.color namespace:
to-lch / to-LCH
from-lch / from-LCH
I'd be happy to open a PR if you can suggest a suitable new name for one out of each pair of vars.

@genmeblog
Copy link
Contributor

Thanks! Didn't know it could be an issue (Windows?).

Let's change to-lch and from-lch to (maybe) to-luma-color-hue and from-luma-color-hue ?
Any other ideas?

PR welcome (it would be great to change also Clerk notebook).

@emlyn
Copy link
Contributor Author

emlyn commented Mar 13, 2023

It's actually MacOS, which (depending on the filesystem used) is case preserving, but not case sensitive when accessing/overwriting files. But I think this could also be an issue on Windows.

Those names sound fine to me, I can't think of anything better. I'll start a PR with the change.

@genmeblog
Copy link
Contributor

Landed on Clojars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants