Free pointer pAdapterInfo before the function nodeIdImpl returns

[mugitya03]

In function nodeIdImpl, the pointer pAdapterInfo at line 8 cannot reach any free site before the function returns at line 19. Thus there is a memory leak bug. Here is the original code:

	pAdapterInfo = reinterpret_cast<IP_ADAPTER_INFO*>(new char[len]);         // memory allocated here
	// Make an initial call to GetAdaptersInfo to get
	// the necessary size into len
	DWORD rc = GetAdaptersInfo(pAdapterInfo, &len);
	if (rc == ERROR_BUFFER_OVERFLOW) 
	{
		delete [] reinterpret_cast<char*>(pAdapterInfo);
		pAdapterInfo = reinterpret_cast<IP_ADAPTER_INFO*>(new char[len]);
	}
	else if (rc != ERROR_SUCCESS)
	{
		return;          // memory leak here
	}

We add a free operation before the return statement.

[CLAassistant]

All committers have signed the CLA.

[slabko]

@mugitya03 thank you very much for your contribution.
This is indeed a memory leak in poco. I can even see that it was been fixed in pocoproject/poco@d11e48f