Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] User-Agent #1948

Merged
merged 5 commits into from
Nov 21, 2024
Merged

[client-v2] User-Agent #1948

merged 5 commits into from
Nov 21, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Nov 19, 2024

Summary

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

}

public static final String LATEST_ARTIFACT_VERSION = "0.7.1-patch1";
public static final String CLIENT_USER_AGENT = "ch-j-v2/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer the full form clickhouse-java-v2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@chernser chernser marked this pull request as ready for review November 21, 2024 06:58
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
25.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@chernser chernser merged commit 1a4bdba into main Nov 21, 2024
59 of 61 checks passed
@chernser chernser deleted the v2_product_name branch November 21, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants