-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[client-v2] Added setting log_comment #1864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Query & Insert Settings share some variables do you think we should extract a common base for team?
Thanks @mzitnik! I've replaced code with shared constant from |
Actually was referring if we can have a common base class since there is shared code |
Quality Gate failedFailed conditions |
@mzitnik I think, we should not do it to keep developer away from idea of extracting common part. |
Summary
There is an option to set a comment that will be seen in
system.query_log
record associated with a query. It is useful for troubleshooting. In case of HTTP interface client should send the comment thru query parameterlog_comment
.Closes: #1836
Checklist
Delete items not relevant to your PR: