Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Fix for case when operation metrics not found #1846

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Sep 30, 2024

Summary

This PR makes sure that ClientStats for operation is always present and do not cause NPE.

Closes #1839

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser added this to the 0.7.0 milestone Sep 30, 2024
@chernser chernser requested review from mzitnik and Paultagoras and removed request for mzitnik September 30, 2024 18:30
Copy link

@chernser chernser changed the title reimplemented in way ClientStats is always not null [client-v2] Fix for case when operation metrics not found Oct 1, 2024
@chernser chernser merged commit f8de038 into main Oct 1, 2024
60 checks passed
@chernser chernser deleted the clientv2_fix_statistics branch October 1, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INSERT query fails occasionally due to issue with ClientStatistics tracking.
2 participants