[client-v2] Compression Support #1761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzitnik
approved these changes
Aug 6, 2024
Contributor
mzitnik
left a comment
mzitnik
left a comment
There was a problem hiding this comment.
In general LGTM, but we need to add tests that can mimic different chunk sizes to simulate edge cases for the compression.
| super(); | ||
| this.decompressor = decompressor; | ||
| this.in = in; | ||
| this.buffer = ByteBuffer.allocate(8192); |
Contributor
There was a problem hiding this comment.
Let's extract it to const & make configurable
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements support for next compression scenarios:
Closes #1717