-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[client-v2] Compression Support #1761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM, but we need to add tests that can mimic different chunk sizes to simulate edge cases for the compression.
super(); | ||
this.decompressor = decompressor; | ||
this.in = in; | ||
this.buffer = ByteBuffer.allocate(8192); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's extract it to const & make configurable
Quality Gate failedFailed conditions |
Summary
Implements support for next compression scenarios:
Closes #1717