Fixed ColumnArray::Slice range check

Enmk · Enmk · commit 3c127a5380f6 · 2022-05-03T23:39:26.000+03:00
diff --git a/clickhouse/columns/array.cpp b/clickhouse/columns/array.cpp
@@ -45,7 +45,7 @@ ColumnRef ColumnArray::GetAsColumn(size_t n) const {
 }
 
 ColumnRef ColumnArray::Slice(size_t begin, size_t size) const {
-    if (size && size + begin >= Size())
+    if (size && begin + size > Size())
         throw ValidationError("Slice indexes are out of bounds");
 
     auto result = std::make_shared<ColumnArray>(data_->CloneEmpty(), DoNotCloneDataColumnTag{});

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ ColumnRef ColumnArray::GetAsColumn(size_t n) const {`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`ColumnRef ColumnArray::Slice(size_t begin, size_t size) const {`
`48`		`- if (size && size + begin >= Size())`
	`48`	`+ if (size && begin + size > Size())`
`49`	`49`	`throw ValidationError("Slice indexes are out of bounds");`
`50`	`50`
`51`	`51`	`auto result = std::make_shared<ColumnArray>(data_->CloneEmpty(), DoNotCloneDataColumnTag{});`