parseDataTimeBestEffort support comma between date and time #42049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-improvement
vdimir
reviewed
Oct 4, 2022
There was a problem hiding this comment.
Maybe '18:31:44, 01/12/2017' is also ok? And can we consider ',' as just a separator between parts and even relax the condition a bit? Then has_comma_after_date would be has_comma_between_date_and_time and used to handle trailing comma cases or multiple commas (by the way, it's good to add '01/12/2017 ,,,, 18:31:44' and similar to tests as parse failing examples).
vdimir
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
parseDataTimeBestEffort support comma between date and time. Closes #42038.