Check what will be if I enable concurrency-mt-unsafe in clang-tidy
#40224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-not-for-changelog
alexey-milovidov
force-pushed
the
alexey-milovidov-patch-4
branch
from
11d5efb to
3649aac
Compare
|
|
||
| using namespace std; | ||
|
|
||
| /// TODO: Remove ME |
There was a problem hiding this comment.
I've implemented this TODO.
| @@ -1,130 +0,0 @@ | |||
| #include <chrono> | |||
There was a problem hiding this comment.
Non-automated test, no one use or support it.
| @@ -1,21 +0,0 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
Non-automated unit test, most likely unneeded.
| @@ -3,10 +3,11 @@ | |||
| #include <fmt/format.h> | |||
|
|
|||
|
|
|||
| std::string errnoToString(int code, int the_errno) | |||
There was a problem hiding this comment.
The usage of the "code" argument was strange and misinterpreted by the callers. I've removed it.
|
I don't understand the result of Debug tests:
|
rschu1ze
approved these changes
Aug 21, 2022
|
@kssenii a test for Azure blob storage has failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):