Rethrow exception on cache initialisation on server startup, better error message #39386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-not-for-changelog
kssenii
changed the title
robot-ch-test-poll2
added
pr-improvement
nickitat
approved these changes
Jul 20, 2022
nickitat
reviewed
Jul 20, 2022
| @@ -45,7 +45,7 @@ void LRUFileCache::initialize() | |||
| catch (...) | |||
| { | |||
| tryLogCurrentException(__PRETTY_FUNCTION__); | |||
| return; | |||
| throw; | |||
There was a problem hiding this comment.
It should be thrown while creating the disk, and it is created in constructor of DIskSelector, which does not catch errors when creating the disks. So I expect that server will fail to start if the exception is thrown here.
01676_long_clickhouse_client_autocomplete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Rethrow exception on filesystem cache initialisation on server startup, better error message.