-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixed in TranslateQualifiedNamesMatcher #38136
Merged
yakov-olkhovskiy
merged 9 commits into
ClickHouse:master
from
bigo-sg:translate_qualified_bug
Jul 1, 2022
Merged
Bug fixed in TranslateQualifiedNamesMatcher #38136
yakov-olkhovskiy
merged 9 commits into
ClickHouse:master
from
bigo-sg:translate_qualified_bug
Jul 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed a bug in TranslateQualifiedNamesMatcher to handle nested tuple field with the table qulified name
yakov-olkhovskiy
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, see some suggestions...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-bugfix
Pull request with bugfix, not backported by default
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed a bug in
TranslateQualifiedNamesMatcher
to handle a nested tuple field with the table qualified name.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
With table
the following query throws an exception of
UNKNOWN_IDENTIFIER
.