Update Parquet results for Hyper #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with how we were handling text columns that are stored as byte arrays in Parquet. With a new option `binary_as_text`, these columns are correctly interpreted as text rather than binary, and the query results are now correct. Once again kudos to Mark Raasveldt who reported this months ago.
rschu1ze
approved these changes
May 4, 2025
Member
rschu1ze
left a comment
rschu1ze
left a comment
There was a problem hiding this comment.
I was able to reproduce the results locally, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with how we were handling text columns that are stored as byte arrays in Parquet. With a new option
binary_as_text, these columns are correctly interpreted as text rather than binary, and the query results are now correct.Once again kudos to Mark Raasveldt (@Mytherin) who reported this months ago.