Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RRTMGP.jl performance #424

Open
simonbyrne opened this issue Jan 11, 2024 · 19 comments · Fixed by #433, #432, #430, #429 or #428
Open

Improve RRTMGP.jl performance #424

simonbyrne opened this issue Jan 11, 2024 · 19 comments · Fixed by #433, #432, #430, #429 or #428
Assignees
@sriharshakandala
Milestone
O1.2.5 1 SYPD for...

Comments

@simonbyrne
Copy link
Member

TODO: set target?
@simonbyrne simonbyrne added this to the O1.2.5 1 SYPD for AMIP milestone Jan 11, 2024
@sriharshakandala
Copy link
Member

sriharshakandala commented Jan 11, 2024 •
edited
Loading

Targets for all-sky problem:
RRTMGP shortwave solve time on (1) V100 for 131,658 cols at 0.98 sec
RRTMGP longwave solve time on (1) V100 for 131,658 cols at 0.85 sec
These targets needs to be adjusted appropriately for P100 and A100 GPUs

@sriharshakandala
Copy link
Member

sriharshakandala commented Jan 11, 2024 •
edited
Loading

Current status:
We are currently at 1.05 sec for the shortwave solver with 131,658 cols on a A100 GPU

This was linked to pull requests Feb 1, 2024
Restructure minor optics computation #433
Merged
Swap dimensions for some lookup data #432
Merged
Restructure longwave RTE solver #430
Merged
Split LW & SW gas optics functions #429
Merged
Simplify parameter types for RTE shortwave solver #428
Merged
Simplify optics parameter types #427
Merged
Replace fld with unsafe_trunc #419
Merged
Store ln(p_ref) instead of p_ref in lookup tables #418
Merged
Simplify optics. #417
Merged
Store cos_zenith instead of zenith #415
Merged
@sriharshakandala
Copy link
Member

sriharshakandala commented Feb 15, 2024 •
edited
Loading

Update OneScalar and TwoStream structs #434

@sriharshakandala
Copy link
Member

sriharshakandala commented Feb 15, 2024 •
edited
Loading

Restructure Source structs #436

@sriharshakandala
Copy link
Member

sriharshakandala commented Feb 15, 2024 •
edited
Loading

Simplify type parameters for AtmosphericState #437

@sriharshakandala
Copy link
Member

sriharshakandala commented Feb 15, 2024 •
edited
Loading

Always inline and remove use of StepRange #438

@sriharshakandala
Copy link
Member

sriharshakandala commented Feb 15, 2024 •
edited
Loading

Restructure LookUpCld to reduce metadata size #442

@sriharshakandala
Copy link
Member

Ease register pressure in GasOptics.jl #443

@sriharshakandala
Copy link
Member

Split shortwave optics function #445

@sriharshakandala
Copy link
Member

sriharshakandala commented Feb 15, 2024 •
edited
Loading

Restructure LookUp tables #449

@sriharshakandala
Copy link
Member

Add lower bound for cumulative optical thickness #448

@sriharshakandala
Copy link
Member

sriharshakandala commented Feb 22, 2024 •
edited
Loading

Remove inferable fields from AtmosphericStates #453

@sriharshakandala
Copy link
Member

Add CloudState #454

@sriharshakandala
Copy link
Member

#531

@sriharshakandala
Copy link
Member

sriharshakandala commented Sep 16, 2024 •
edited
Loading

Change data layout for fluxes #532

@sriharshakandala
Copy link
Member

Change data layout for optical properties #533

@sriharshakandala
Copy link
Member

Change data layout for sources #534

@sriharshakandala
Copy link
Member

Change data layouts for pressure, temperature, col_dry and relative humidity #535

@sriharshakandala
Copy link
Member

Change data layout for Vmr #536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sriharshakandala sriharshakandala

Labels
None yet
Projects
None yet
Milestone
O1.2.5 1 SYPD for AMIP
2 participants
@simonbyrne @sriharshakandala