Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NCDatasets compats in environments #394

Closed
Sbozzolo opened this issue Nov 1, 2023 · 8 comments · Fixed by #395
Closed

Update NCDatasets compats in environments #394

Sbozzolo opened this issue Nov 1, 2023 · 8 comments · Fixed by #395

Comments

@Sbozzolo
Copy link
Member

Sbozzolo commented Nov 1, 2023

See discussion in Alexander-Barth/NCDatasets.jl#233

@charleskawczynski
Copy link
Member

Wait, RRTMGP doesn't depend on NCDatasets

@charleskawczynski
Copy link
Member

Ah, the test environment does. So we should update the compat there.

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Nov 1, 2023

c135293 adds NCDatasets to RRTMGP.

The intent of this issue is to remind us that we should fix the issue at the root instead of pinning NCDatasets in RRTMGP (which indeed does not depend on NCDataset)

@charleskawczynski
Copy link
Member

That doesn't add it to the package, only to the test, gpuenv, and examples environments

@charleskawczynski
Copy link
Member

We shouldn't pin it in the root, then we'll need to add it as a direct dependency.

@charleskawczynski
Copy link
Member

We can pin it in ClimaAtmos, that'll determine which version is used there anyway.

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Nov 1, 2023

That doesn't add it to the package, only to the test, gpuenv, and examples environments

You are right! I didn't pay enoguh attention

We can pin it in ClimaAtmos, that'll determine which version is used there anyway.

CliMA/ClimaAtmos.jl#2319

@charleskawczynski charleskawczynski changed the title RRTMGP incompatible with NCDatasets 0.13 Update NCDatasets compats in environments Nov 2, 2023
@charleskawczynski
Copy link
Member

Let's keep this open (I've updated the title)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants