-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NCDatasets compats in environments #394
Comments
Wait, RRTMGP doesn't depend on NCDatasets |
Ah, the test environment does. So we should update the compat there. |
c135293 adds NCDatasets to RRTMGP. The intent of this issue is to remind us that we should fix the issue at the root instead of pinning NCDatasets in RRTMGP (which indeed does not depend on NCDataset) |
That doesn't add it to the package, only to the |
We shouldn't pin it in the root, then we'll need to add it as a direct dependency. |
We can pin it in ClimaAtmos, that'll determine which version is used there anyway. |
You are right! I didn't pay enoguh attention
|
Let's keep this open (I've updated the title) |
See discussion in Alexander-Barth/NCDatasets.jl#233
The text was updated successfully, but these errors were encountered: