-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Interpolations.jl #44
Conversation
caae637
to
c71946e
Compare
Hmm, the docs are breaking, and the tests have all sorts of issues. Maybe we can fix the tests first. |
What issues do you see in tests? Aren't they all passing? |
The error in the docs is because by default |
Sorry, I meant that the design of the tests in this repo need improvement-- Right now, the things that are tested are implicit, based on |
I think #45 fixes all of this. |
Sorry about all the conflicts, I can rebase if you'd like |
c71946e
to
a800430
Compare
Rebased |
491fad9
to
fcd5725
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Results in the docs look visually indistinguishable.
Note that the order of interpolation is now first instead of cubic.
Is this acceptable?
Closes #43
Closes #39