-
Notifications
You must be signed in to change notification settings - Fork 5
Master - Add Unity 6 application entry point note to CleverTap integration docs #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a new subsection under the CleverTap Integration Update section to clarify Unity 6 Application Entry Point settings. The update instructs developers to select the Activity option (instead of GameActivity) when using CleverTap with Leanplum, ensuring correct configuration in Unity 6 Android Player settings.
…levertap Add - Unity 6 application entry point note to CleverTap integration docs
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
WalkthroughAdds a documentation subsection to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/Instructions-Android.md (1)
35-46: Restructure the content to remove indentation within the numbered list.The new subsection is indented (lines 35–46) because it appears within a numbered list item (item 2, starting at line 20). Consider restructuring the placement to avoid indentation of headings, which violates Markdown best practices.
You could either:
- Move the Unity 6 section outside the numbered list structure
- Use inline formatting (bold text, etc.) instead of a heading within the list item
For example, if moving outside the list:
Otherwise use `com.clevertap.unity.CleverTapOverrideActivity` as shown in the Manifest below. + +### Unity 6 – Application Entry Point Consideration + +In **Unity 6**, the Android Player settings provide two application entry point options: + +- **Activity** +- **GameActivity** + +For CleverTap integration, ensure that the **Activity** option is selected in: + +```text +Project Settings → Player → Android → Other Settings → Application Entry Point +``` - #### Unity 6 – Application Entry Point Consideration - ...
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/Instructions-Android.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/Instructions-Android.md
36-36: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4
(MD001, heading-increment)
36-36: Headings must start at the beginning of the line
(MD023, heading-start-left)
44-44: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
…block Corrected a Markdown heading that violated linting rules by adjusting it from an indented level-4 heading to a proper level-3 heading. Also added a `text` language identifier to a fenced code block to comply with Markdown lint requirements for code block language specification.
Added a new subsection under the CleverTap Integration Update section to clarify Unity 6 Application Entry Point settings.
The update instructs developers to select the Activity option (instead of GameActivity) when using CleverTap with Leanplum, ensuring correct configuration in Unity 6 Android Player settings.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.