Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Xedra Evolved ] Vampire cure is broken once again (need working suggestions) #78774

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Maleclypse
Copy link
Member

Summary

None

Purpose of change

Vampire cure is broken again.

Describe the solution

Make vampire cure work again. (Doesn't currently work)

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Xedra Evolved Anything to do with Xedra Evolved json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 26, 2024
@SariusSkelrets
Copy link
Contributor

The lilin drain EOC works as intended and changes an effect intensity by refering the current intensity.

      {
        "u_add_effect": "effect_lilin_ruach_drain_side_effects",
        "intensity": { "math": [ "u_effect_intensity('effect_lilin_ruach_drain_side_effects') + 1" ] },
        "duration": [ "72 h", "72 h" ]
      },

Writting the vampire cure code to lower the intensity this way and including a check to remove zero-intensity effects if it doesn't happen on its own is likely to work.

@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 26, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants