Improve forest generation next to rivers and lakes #68750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Improve forest generation next to rivers and lakes"
Purpose of change
Fixes #54040
Describe the solution
Simply add rivers and lakes to the forest biome, since that seems to determine how the feathering works.
I should mention that I have no idea of possible side effects of this. At least I didn't see anything obvious while teleporting around.
Describe alternatives you've considered
Testing
Teleported around a bunch and looked at results. Here are a bunch of unnecessarily large, zoomed out images:
Single tile forest island in a lake
New
Old
4 tile forest island in a lake
New
Old
3 tile forest island with cabin and boat
New
Old
single tile swamp island in a lake
New
Old
small forest island in a river
New (3 tiles)
Old (1 tile)
River peninsula starting as field with forest at the tip
New (2 field, 1 regular forest)
Old (field to regular forest to thick forest)
normal forest along a river
New
Old
thick forest along a river
New
Old
(I have a few more images, but it's tiring adding them here and it's really just more of the same.)
Additional context
Not sure why
island_forest(_thick)has rotations, but it is how it is.