-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grammar/Spelling #38006
Grammar/Spelling #38006
Conversation
You appear to have deleted all your changes with that last update. |
You should never edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure there's value in changing comments to remove regional spelling.
Why so much editing to .po files? Does it have any actual effect
You should see Given how many times we've been repeating this, we should probably add it as an automated check to warn about it to unknowing contributers. |
I don't think an automated check would fix things since they're already in the PR stage by then |
But the author would see the warning and revert the changes before we have to tell them to do so. (Well at least if they are paying attention to the check status) |
Wouldn't it affect expected i18n PRs from @BrettDong? Or we would need to add some kind of whitelist for PR author to the check? |
This reverts commit 9a78ab5.
@ZhilkinSerg If a PR is an authentic i18n update we can just ignore the warning and merge it. |
Summary
SUMMARY: Bugfixes "Fixes various punctuation and spelling errors."
Purpose of change
Describe the solution
Describe alternatives you've considered
Testing
Additional context