Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companions (NPCs) provide general advice (hints) #29535

Merged
merged 1 commit into from
Apr 14, 2019
Merged

Companions (NPCs) provide general advice (hints) #29535

merged 1 commit into from
Apr 14, 2019

Conversation

nexusmrsep
Copy link
Contributor

Summary

SUMMARY: Features "Companions provide general advice (hints)"

Purpose of change

Hints, that were originally designed to lead new players, were only given by NPC in a Refugee Center.
Problem with this is: if you got to Refugee Center its probably mid- or late-game and you don't need much hints anymore at that point.

Describe the solution

  • Allowed any companion to provide hints.
  • To prevent spamming companions for hints, it limited to 1 hint per 30 minutes time.

Describe alternatives you've considered

There is nice library of hints, but it may need revision (update). New hints would be also great.

Additional context

Also a small fix to "ASK_TO_TRAIN" was added to check for other relevant conditions.

@nexusmrsep nexusmrsep added <Enhancement / Feature> New features, or enhancements on existing NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON labels Apr 13, 2019
@DracoGriffin
Copy link
Contributor

As we progress towards more conversation options, backstories, NPC base stuff, it becomes more relevant that we need to place them all under a "Conversation" option that then offers these choices.

Not saying you need to do that nexus, just making an observation.

Otherwise, looks good to me as a suitable use for hints.

Copy link
Contributor

@mlangsdorf mlangsdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NPC is giving you a hint, not instructing you in how to make diamond katanas. He should be able to do it while you're driving or he's hungry or whatever. Nevertheless, this is fine as it is.

@ZhilkinSerg ZhilkinSerg merged commit 823e43b into CleverRaven:master Apr 14, 2019
@nexusmrsep nexusmrsep deleted the companion_hints branch April 14, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants