Fix CMake curses build #26741
Merged
Fix CMake curses build #26741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a fix to add -ltinfo where necessary, which is required to get the curses version to link on my system. I pulled this from the CMake 3.0.0 distribution, which entailed adding a bunch of other cmake files from the same place which are dependencies of the new FindCurses.
|
Congrats, you own CMake builds now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Build "Fixed CMake curses build"
Purpose of change
The CMake curses build did not work on my system, because it fails to link against
tinfo.Describe the solution
Update
FindCurses.cmake. This includes a fix to add -ltinfo where necessary, which is required toget the curses version to link on some systems.
I pulled this from the CMake 3.0.0 distribution, which entailed adding a bunch of other cmake files from the same place which are dependencies of the new FindCurses.
Here's where the relevant feature was added to CMake:
https://gitlab.kitware.com/cmake/cmake/commit/1f646c6ce0766f8ab59868e7cac24034e6966504
The new file depends on a bunch of other
.cmakefiles from that release, so I had to include those also.Because I took the file from CMake 3.0.0 I have updated the required version of CMake to that in case there are any features of that version being relied upon.
I had to make one small tweak to one file to avoid a CMake policy warning from running under CMake 3.10.
Additional context
This is a step towards being able to use CMake to generate compilation databases and thus use clang tooling.
I'm not a CMake expert and there's no CI for the CMake build, so I welcome any thoughts on potential problems this might cause.