Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character creation - Traits tab - UI audit #58265

Open
8 tasks
ZeroInternalReflection opened this issue Jun 8, 2022 · 4 comments
Open
8 tasks

Character creation - Traits tab - UI audit #58265

ZeroInternalReflection opened this issue Jun 8, 2022 · 4 comments
Labels
Accessibility Issues regarding accessibility Character / World Generation Issues and enhancements concerning stages of creating a character or a world Info / User Interface Game - player communication, menus, etc. (P5 - Long-term) Long-term WIP, may stay on the list for a while. (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@ZeroInternalReflection
Copy link
Contributor

Describe the bug

The traits tab of the character creation screen has several graphical and navigational issues. Some of these overlap with other character creation issues, but most appear to be independent. These include:

Display issues:
1] Appearance names are cut off on small screens
2] Trait costs wrap around and print over the border on small screens
Character creation - Traits - Cut off text – 80x24
3] Trait names are cut off on small screens in non-English languages (Polish shown):
Character creation - Traits --  80x24 – Polish
4] Some trait descriptions are cut off in non-English languages
5] In Russian, and possibly other non-English languages, changing the sort mode changes the location of the sort hint
Character creation - Traits - Sorted by points -- 80x24 -- Russian - With cut off description
Character creation - Traits - Unsorted -- 80x24 -- Russian
Accessibility issues:
6] The cursor is not set for screen readers
Navigation issues:
7] No mouse support is available
8] A hint is shown for filtering, but the filter keybinding is not shown

Steps to reproduce

  1. Open the game
  2. Set language specified (if applicable)
  3. Resize window to size specified (if described as 'small', assume 80x24)
  4. New game
  5. Custom character
  6. Tab to "TRAITS"

Expected behavior

  • 1] Appearance names should truncate/fold cleanly at all screen sizes in all supported languages
  • 2] Change to "This trait costs x points"
  • 3] Trait names should truncate/fold cleanly
  • 4] Trait descriptions should be scrollable
  • 5] The keybinding hints should be in a consistent location
  • 6] The cursor should be set for screen readers according to accessibility.md
  • 7] It should be possible to: toggle traits with left-click, scroll through active trait list with mousewheel, and select a different tab with left click
  • 8] The filter hotkey / should be shown in the filter hint

Screenshots

No response

Versions and configuration

Tiles
  • OS: Linux
    • OS Version: LSB Version: n/a; Distributor ID: Arch; Description: Arch Linux; Release: rolling; Codename: n/a;
  • Game Version: 90e1eb2 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]
Curses

Additional context

For clarification of some of my UI terminology (e.g. scroll vs. fast scroll, column vs. pane), refer to my general notes here

@ZeroInternalReflection ZeroInternalReflection added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jun 8, 2022
@Maleclypse Maleclypse added Info / User Interface Game - player communication, menus, etc. (S2 - Confirmed) Bug that's been confirmed to exist (P5 - Long-term) Long-term WIP, may stay on the list for a while. Character / World Generation Issues and enhancements concerning stages of creating a character or a world and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jun 8, 2022
@Zireael07
Copy link
Contributor

Hey OP, maybe it's worth creating a tracker for those? I think it's like the 5th detailed audit that you've submitted (Awesome btw!)

@NetSysFire NetSysFire added the Accessibility Issues regarding accessibility label Jun 8, 2022
@NetSysFire
Copy link
Member

maybe it's worth creating a tracker for those?

You mean a project? This kanban-thing at https://github.com/CleverRaven/Cataclysm-DDA/projects?
Unfortunately it requires certain special permissions to the repo to modify so adding and removing items is impossible to do on your own

@Zireael07
Copy link
Contributor

No, a tracker issue. An issue that is formatted as a to-do list with a list of links to all the related issues.

@ZeroInternalReflection
Copy link
Contributor Author

Some sort of central tracking for these issues (and other related UI issues) is probably a good idea. There was a brief discussion of setting up a project for this on Discord. Of course, there are already a couple of (largely dormant, I think) UI projects there.
I'm not sure whether a project or a tracking issue would be the better way to track these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues regarding accessibility Character / World Generation Issues and enhancements concerning stages of creating a character or a world Info / User Interface Game - player communication, menus, etc. (P5 - Long-term) Long-term WIP, may stay on the list for a while. (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

4 participants