Skip to content

Trading with NPCs does not update the Volume/Weight indicator for contained items #40175

Closed
@Resok

Description

Describe the bug

When trading with an NPC, the volume only updates when trading their currently worn/equipped items. This also includes items that are currently providing their storage capacity.

Steps To Reproduce

  1. Equip NPC and make them friendly (either through normal gameplay or debug commands)
  2. Open trade menu with NPC
  3. Select trade items from their side (left side)
  4. Observe Volume and Weight indicators

Expected behavior

When I'm attempting to remove an item from an NPC that is contained within their worn containers then the Volume/Weight indicator should update with the new totals. Trading that removes an item with storage should also not preview that it's adding available volume to the NPC.

Screenshots

image

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1909
  • Game Version: 0.E-1758-g7161a41 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Magiclysm [magiclysm],
    Medieval Mod Reborn [Medieval_Mod_Reborn],
    Stats Through Skills [StatsThroughSkills],
    Mutant Animals [mutant_animals],
    Mutant Insects [mutant_insects],
    Classes and Scenarios Mod [more_classes_scenarios],
    Sleep Deprivation [sleepdeprivation]
    ]

Additional context

This seems to be related to the recent containers inventory logic not meshing well with the NPC inventory/trade UI.

Metadata

Assignees

No one assigned

    Labels

    <Bug>This needs to be fixedInventory / AIM / ZonesInventory, Advanced Inventory Management or ZonesItems: ContainersThings that hold other thingsNPC / FactionsNPCs, AI, Speech, Factions, Ownership

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions