Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iron solder with UPS mod can't be used to dismantle robots #31815

Closed
Leosky opened this issue Jun 24, 2019 · 3 comments
Closed

Iron solder with UPS mod can't be used to dismantle robots #31815

Leosky opened this issue Jun 24, 2019 · 3 comments
Labels
(S3 - Duplicate) Bug that is duplicate of another one

Comments

@Leosky
Copy link
Contributor

Leosky commented Jun 24, 2019

Describe the bug

Iron solder with UPS mod can't be used to dismantle robots

Steps To Reproduce

Mod a soldering iron with UPS convertion and try to dissmantle a robot. It shouldn't be possible.

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1903
  • Game Version: 0.D-4929-gdd1dfac [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Magiclysm [magiclysm],
    Medieval and Historic Classes and Shields [Medieval_Stuff],
    Craftable Gun Pack [craftgp],
    DeadLeaves' Fictional Guns [FIC_Weapons],
    Icecoon's Arsenal [ew_pack],
    Makeshift Items Mod [makeshift],
    More Survival Tools [More_Survival_Tools],
    Modular Turrets [modular_turrets],
    Salvaged Robots [Salvaged_Robots],
    Mutant NPCs [mutant_npcs],
    Beta National Guard Camp [national_guard_camp],
    More Locations [more_locations],
    Fuji's More Buildings [FujiStruct],
    Folding Parts pack [deoxymod],
    Larger Vehicules Containers [LargerVehiculesContainers],
    Vehicle Additions Pack [blazemod],
    Tanks and Other Vehicles [Tanks],
    [DP_MOD] Indicators: Xotto [DP_XOTTO_INDICATORS],
    sees-player icon, +attitude [sees_player],
    SpeedyDex [speedydex],
    StatsThroughSkills [StatsThroughSkills],
    Simplified Nutrition [novitamins],
    Disable NPC Needs [no_npc_food]
    ]
@ghost
Copy link

ghost commented Jun 25, 2019

Sounds like #29961 which still hasnt been fixed.

@Inglonias
Copy link
Contributor

Yeah, my fix for UPS modded itms mainly worked with iuse, which isn't the whole story. This is something that cannot be fixed all at once without serious refactoring. Nevertheless, we know the general cure now (find whatever is calling ammo_remaining or ammo_sufficient regarding the tool and replace that call with units_remaining or units_sufficient)

@ifreund
Copy link
Contributor

ifreund commented Jun 26, 2019

Closing as a duplicate of #29961

@ifreund ifreund closed this as completed Jun 26, 2019
@ifreund ifreund added the (S3 - Duplicate) Bug that is duplicate of another one label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S3 - Duplicate) Bug that is duplicate of another one
Projects
None yet
Development

No branches or pull requests

3 participants